Skip to content

refactor(navigation-menu): rewrite machine logic #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Nov 11, 2025
Merged

refactor(navigation-menu): rewrite machine logic #2678

merged 43 commits into from
Nov 11, 2025

Conversation

@segunadebayo
Copy link
Member

@segunadebayo segunadebayo commented Sep 2, 2025 •
edited by nelsonlaidev
Loading

Closes #

📝 Description

Rewrite the nav-menu machine so we can ship it

Updates by @nelsonlaidev

  • Exported missing types.
  • Added navigation-menu example for svelte.
  • Added missing VALUE.SET event.
  • Added missing id for getItemProps.
  • Added core e2e tests.
  • Used itemState.getPARTId when available
  • Fixed a bug where elements get stuck in unmountSuspended state during rapid hovering.
  • Make instant response time when moving between trigger.
  • Removed onPointerMove and related context/variables/functions.
  • Removed nested navigation menu.
  • Removed escapeCloseValue.
  • Removed clickCloseValue.
  • Removed unnecessary non-null assertion operator on prop(“orientation“).
  • Removed unnecessary/unused indicator ElementId.
  • Fixed that unable to handle arrow key navigation between triggers.

@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c71f549

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 81 packages
Name Type
@zag-js/presence Patch
@zag-js/anatomy-icons Patch
@zag-js/anatomy Patch
@zag-js/core Patch
@zag-js/docs Patch
@zag-js/preact Patch
@zag-js/react Patch
@zag-js/solid Patch
@zag-js/svelte Patch
@zag-js/vue Patch
@zag-js/accordion Patch
@zag-js/angle-slider Patch
@zag-js/async-list Patch
@zag-js/avatar Patch
@zag-js/bottom-sheet Patch
@zag-js/carousel Patch
@zag-js/checkbox Patch
@zag-js/clipboard Patch
@zag-js/collapsible Patch
@zag-js/color-picker Patch
@zag-js/combobox Patch
@zag-js/date-picker Patch
@zag-js/dialog Patch
@zag-js/editable Patch
@zag-js/file-upload Patch
@zag-js/floating-panel Patch
@zag-js/hover-card Patch
@zag-js/image-cropper Patch
@zag-js/listbox Patch
@zag-js/marquee Patch
@zag-js/menu Patch
@zag-js/navigation-menu Patch
@zag-js/number-input Patch
@zag-js/pagination Patch
@zag-js/password-input Patch
@zag-js/pin-input Patch
@zag-js/popover Patch
@zag-js/progress Patch
@zag-js/qr-code Patch
@zag-js/radio-group Patch
@zag-js/rating-group Patch
@zag-js/scroll-area Patch
@zag-js/select Patch
@zag-js/signature-pad Patch
@zag-js/slider Patch
@zag-js/splitter Patch
@zag-js/steps Patch
@zag-js/switch Patch
@zag-js/tabs Patch
@zag-js/tags-input Patch
@zag-js/timer Patch
@zag-js/toast Patch
@zag-js/toggle-group Patch
@zag-js/toggle Patch
@zag-js/tooltip Patch
@zag-js/tour Patch
@zag-js/tree-view Patch
@zag-js/store Patch
@zag-js/types Patch
@zag-js/aria-hidden Patch
@zag-js/auto-resize Patch
@zag-js/collection Patch
@zag-js/color-utils Patch
@zag-js/utils Patch
@zag-js/date-utils Patch
@zag-js/dismissable Patch
@zag-js/dom-query Patch
@zag-js/file-utils Patch
@zag-js/focus-trap Patch
@zag-js/focus-visible Patch
@zag-js/highlight-word Patch
@zag-js/hotkeys Patch
@zag-js/i18n-utils Patch
@zag-js/interact-outside Patch
@zag-js/json-tree-utils Patch
@zag-js/live-region Patch
@zag-js/popper Patch
@zag-js/rect-utils Patch
@zag-js/remove-scroll Patch
@zag-js/scroll-snap Patch
@zag-js/stringify-state Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
zag-nextjs Ready Ready Preview Nov 11, 2025 11:22am
zag-solid Ready Ready Preview Nov 11, 2025 11:22am
zag-svelte Ready Ready Preview Nov 11, 2025 11:22am
zag-vue Ready Ready Preview Nov 11, 2025 11:22am
zag-website Ready Ready Preview Nov 11, 2025 11:22am

@segunadebayo segunadebayo changed the title navigation-menu: rewrite logic refactor(navigation-menu): rewrite machine logic Sep 2, 2025
@segunadebayo segunadebayo marked this pull request as ready for review November 11, 2025 13:00
@segunadebayo segunadebayo merged commit 3171668 into main Nov 11, 2025
21 checks passed
@segunadebayo segunadebayo deleted the refactor/nav-menu branch November 11, 2025 18:24
@github-actions github-actions bot mentioned this pull request Nov 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@segunadebayo @nelsonlaidev